Messages in this thread | | | Date | Tue, 13 Jul 2004 14:54:24 -0700 | From | Andrew Morton <> | Subject | Re: [linux-audio-dev] Re: [announce] [patch] Voluntary Kernel Preemption Patch |
| |
Andrea Arcangeli <andrea@suse.de> wrote: > > On Tue, Jul 13, 2004 at 11:48:29AM -0700, Andrew Morton wrote: > > sys_sched_yield() also calls schedule() with local interrupts disabled. > > It's a bit grubby, but saves a few cycles. Nick and Ingo prefer it that way. > > we can remove the irqs_disabled() check in might_sleep then, I'd like to > call might_sleep from cond_resched.
Confused. Where do we call cond_resched() with local interrupts disabled?
Sleeping with local interrupts disabled is usually a bug, so we should prefer to keep that check in might_sleep(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |