lkml.org 
[lkml]   [2004]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] preset loops_per_jiffy for faster booting
On Fri, Jul 09, 2004 at 07:01:58PM -0700, Todd Poynor wrote:
> Adam Kropelin wrote:
>
> > + if (preset_lpj) {
> > + loops_per_jiffy = preset_lpj;
> > + printk("Calibrating delay loop (skipped)... ");
>
> Suggest a "\n" at the end of that.

Indeed. I propogated that bug from the original patch. I'll fix it.

> Maybe add the precomputed value to
> help bring incorrect presets to someone's attention, something like:
>
> + printk("BogoMIPS preset to %lu.%02lu\n",
> + loops_per_jiffy/(500000/HZ),
> + (loops_per_jiffy/(5000/HZ)) % 100);

Will do.

> > + If unsure, set this to 0. An incorrect value will cause delays in
> > + the kernel to be incorrect. Although unlikely, in the extreme case
> > + this might damage your hardware.
>
> I suppose it may result in unpredictable I/O errors, in case we want to
> warn against that.

Easy enough to throw it in.

Another patch is forthcoming.

--Adam

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.038 / U:0.500 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site