Messages in this thread | | | From | Kevin Corry <> | Subject | Re: [PATCH] 1/1: Device-Mapper: Remove 1024 devices limitation | Date | Thu, 1 Jul 2004 21:54:16 -0500 |
| |
On Thursday 01 July 2004 16:38, Andrew Morton wrote: > Kevin Corry <kevcorry@us.ibm.com> wrote: > > Remove the limitation of 1024 DM devices. > > That seems to be an awful lot of fuss just to maintain a bitmap.
Mmm...perhaps.
> What is a realistic useful upper bound on the minors? Would it not be > sufficient to increase the size of the statically allocated bitmap?
I guess that depends on who you ask. Obviously, for most people the previous limit of 1024 devices is more than enough. But there's always going to be folks pushing the limits. So I figured I'd go ahead and rewrite it to theoretically allow for the maximum range of minor numbers, while trying not to waste memory for the common case.
> Did you consider going to a different data structure altogether? > lib/radix-tree.c and lib/idr.c provide appropriate ones.
The idr stuff looks promising at first glance. I'll take a better look at it tomorrow and see if we can switch from a bit-set to one of these data structures.
-- Kevin Corry kevcorry@us.ibm.com http://evms.sourceforge.net
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |