lkml.org 
[lkml]   [2004]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] task name handling in proc fs
    On Thu, Jul 01, 2004 at 03:19:35PM -0700, Andrew Morton wrote:
    > Mike Kravetz <kravetz@us.ibm.com> wrote:
    > >
    > > --- linux-2.6.7/fs/proc/array.c Wed Jun 16 05:19:36 2004
    > > +++ linux-2.6.7.ptest/fs/proc/array.c Thu Jul 1 17:44:14 2004
    > > @@ -97,14 +97,14 @@
    > > name++;
    > > i--;
    > > *buf = c;
    > > - if (!c)
    > > + if (!*buf)
    > > break;
    > > - if (c == '\\') {
    > > - buf[1] = c;
    > > + if (*buf == '\\') {
    > > + buf[1] = *buf;
    > > buf += 2;
    > > continue;
    > > }
    > > - if (c == '\n') {
    > > + if (*buf == '\n') {
    > > buf[0] = '\\';
    > > buf[1] = 'n';
    > > buf += 2;
    >
    > What is this code for?

    The code is copying the task name from 'c' to 'buf' one character
    at a time. It is then 'post processing' the characters. Currently,
    the post processing is based on the value of c which is part of the
    source string (task->curr). However, it is possible for the source
    string to change during this copy (think exec). In such a case I
    think it is better to base the 'post processing' on the character
    that already has been safely been copied to the target string rather
    than the character in the source string which might have changed.

    --
    Mike
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:04    [W:0.024 / U:88.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site