lkml.org 
[lkml]   [2004]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [STACK] weird code in some isdn drivers
On Wed, Jun 09, 2004 at 02:36:33PM +0200, Jörn Engel wrote:
> Karsten, Kai,
>
> while I agree that this is a measurement bug, it's not exacly fun to
> look at the code in question. Can you please find a solution for
> hscx_irq.c?

HiSax and I4L is in bugfix only mode, since it will replaced
by other drivers. So I do not want waste time for soon obsolate code.

>
> Either transform it into a header and uninline some of the longer
> functions or make the functions global and add the necessary header
> and Makefile-line. In any case, I don't like to see something like
> #include "hscx_irq.c"
>

Yes I agree that it looks ugly and make not much more sense with today
CPUs and compilers. In the beginning of the development (on 386/486) and
with early GCC (inline was often broken) it did and reduced some
ping times so far I remember. (~1997)

> stackframes for call path too long (268435490):
> size function
> 0 IsdnCardState->irq_func
> 268435466 teles3_interrupt
> 24 hscx_empty_fifo
> 0 read_fifo
> 0 insb
>
> Jörn
>
> --
> People will accept your ideas much more readily if you tell them
> that Benjamin Franklin said it first.
> -- unknown

--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.043 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site