lkml.org 
[lkml]   [2004]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[VGA16FB] Fix bogus mem_start value
From
Hi Andrew:

The recent change to vga16fb's memory mapping that you partially
reverted is still broken. In particular, it's setting fix.mem_start
to a virtual address on i386. The value of fix.mem_start is meant
to be physical.

We could simply apply virt_to_phys to it, but somehow I doubt that
is what it's meant to do on arm. So until we hear from someone who
knows how it works on arm, let's just revert this change.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
===== drivers/video/vga16fb.c 1.38 vs edited =====
--- 1.38/drivers/video/vga16fb.c 2004-05-22 18:18:20 +10:00
+++ edited/drivers/video/vga16fb.c 2004-06-08 19:57:40 +10:00
@@ -1372,8 +1372,6 @@
vga16fb.par = &vga16_par;
vga16fb.flags = FBINFO_FLAG_DEFAULT;

- vga16fb.fix.smem_start = VGA_MAP_MEM(vga16fb.fix.smem_start);
-
i = (vga16fb_defined.bits_per_pixel == 8) ? 256 : 16;
ret = fb_alloc_cmap(&vga16fb.cmap, i, 0);
if (ret) {
\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.037 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site