lkml.org 
[lkml]   [2004]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] stop page_state stack waste
    On Tue, 8 Jun 2004, Andrew Morton wrote:
    > Hugh Dickins <hugh@veritas.com> wrote:
    > >
    > > Replace get_page_state (which memset most of full page_state to 0) by
    > > get_main_page_state, which just sets the small structure needed. This
    > > helps 4k stacks not to overflow: cuts 224 bytes off try_to_free_pages
    > > and wakeup_bdflush (and sync_inodes_sb) stack usages: wakeup_bdflush
    > > doesn't do much, but is called by try_to_free_pages and mempool_alloc.
    >
    > Yeah, I was looking at that. I simply did:
    > -} ____cacheline_aligned;
    > +};

    Well, that is a smaller patch; but you're still wasting 124 bytes of
    stack in wakeup_bdflush below 124 bytes wasted in try_to_free_pages.

    Hugh

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:0.019 / U:152.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site