Messages in this thread Patch in this message | | | Date | Mon, 7 Jun 2004 21:41:42 +0100 | From | Christoph Hellwig <> | Subject | Re: Linux 2.6.7-rc3 |
| |
On Mon, Jun 07, 2004 at 12:32:45PM -0700, Linus Torvalds wrote: > > Ok, let's calm down for a while before the final 2.6.7. > > -rc3 does a lot of sparse type cleanup, mainly thanks to Al Viro (but his > work ended up getting some other people involved too, since the list of > sparse warnings isn't as daunting any more). Some of that has unearthed > real bugs which Al fixed. > > But there are DRM, AGP, cpufreq, sparc64, and input updates there too. See > the appended shortlog for more details,
This one here:
diff -Nru a/include/linux/netfilter_arp.h b/include/linux/netfilter_arp.h --- a/include/linux/netfilter_arp.h 2004-06-07 21:58:09 +02:00 +++ b/include/linux/netfilter_arp.h 2004-06-07 21:58:09 +02:00 @@ -17,4 +17,5 @@ #define NF_ARP_FORWARD 2 #define NF_ARP_NUMHOOKS 3
+static DECLARE_MUTEX(arpt_mutex); #endif /* __LINUX_ARP_NETFILTER_H */ looks perfectly fucked up. This way every file including netfilter_arp.h will get it's own copy of arpt_mutex which certainly doesn't help synchronization.
But in fact I can only see a single file actually using it, that's arp_tables.c where it was defined previously. What's going on here?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |