Messages in this thread | | | Date | Mon, 7 Jun 2004 09:03:07 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH 2.4] jffs2 aligment problems |
| |
On Mon, 7 Jun 2004, Thomas Gleixner wrote: > > On Monday 07 June 2004 17:08, Greg Weeks wrote: > > This fixed some jffs2 alignment problems we saw on an IXP425 based > > XScale board. I just got pinged that I was supposed to post this patch > > in case anyone else finds it usefull. This was against a modified 2.4.19 > > kernel. > > Enable CONFIG_ALIGNMENT_TRAP instead of tweaking the code. > JFFS2 / MTD must be allowed to do unaligned access
Wrong.
Pleas fix jffs2 to use the proper "get_unaligned()"/"put_unaligned()" instead.
Emulating unaligned accesses with traps (even even the architecture supports it, which isn't universally true) is _stupid_ when we have perfectly well-defined macros for them that do it faster and are _designed_ for this.
On architectures where it doesn't matter, the macros just do the access, so it's not like you're slowing anything down.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |