lkml.org 
[lkml]   [2004]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] ASLA design, depth of code review and lack thereof
At Mon, 07 Jun 2004 09:47:40 -0400,
Jeff Garzik wrote:
>
> Takashi Iwai wrote:
> > At Fri, 04 Jun 2004 19:37:54 -0400,
> > Jeff Garzik wrote:
> >
> >>
> >>While we're bitching about ALSA, can we please kill the
> >>subsystem-specific malloc and "magic cast" wrappers?
> >>This debug machinery is better done elsewhere...
> >
> >
> > Of course we can remove kmalloc/vmalloc wrappers for cast checking
> > once when the kernel core provides a similar debugging mechanism.
> > Do you know any alternative?
>
>
> CONFIG_DEBUG_SLAB and CONFIG_DEBUG_PAGEALLOC. Other stuff should go
> into ALSA developer trees or use of a debugger, not be in mainline
> kernel code.

They're nice but they don't provide "cast checking", no?
The main purpose of the magic_* stuffs in ALSA is to check the cast of
the void pointer back to the original data type, which the compiler
can't check.

Maybe we can implement only this "magic" check separetly and get rid
of allocation checks, but I'm not sure whether it's worthy to do
that.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.072 / U:3.440 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site