Messages in this thread | | | Subject | Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing | From | Andreas Schwab <> | Date | Sat, 05 Jun 2004 23:47:22 +0200 |
| |
"David S. Miller" <davem@redhat.com> writes:
> On Sat, 05 Jun 2004 23:21:53 +0200 > Andreas Schwab <schwab@suse.de> wrote: > >> "David S. Miller" <davem@redhat.com> writes: >> >> > This means also that Olaf's patch is broken, when CONFIG_COMPAT is not >> > set, MSG_CMSG_COMPAT is zero, thus ~MSG_CMSG_COMPAT is the unexpected >> > value all 1's thus breaking the tests for unexpected flags completely. >> >> ??? Where do you get ~MSG_CMSG_COMPAT from? > > Olaf's patch, it said: > > - if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC)) > + if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC|MSG_CMSG_COMPAT))
Yes, and where is the problem?
Andreas.
-- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |