Messages in this thread | | | Subject | Re: [PATCH] PPC64: lockfix for rtas error log | From | Benjamin Herrenschmidt <> | Date | Tue, 29 Jun 2004 20:44:26 -0500 |
| |
On Tue, 2004-06-29 at 17:50, linas@austin.ibm.com wrote: > Paul, > > Could you please apply the following path to the ameslab tree, and/or > forward it to the main 2.6 kernel maintainers. > > This patch moves the location of a lock in order to protect > the contents of a buffer until it has been copied to its final > destination. Prior to this, a race existed whereby the buffer > could be filled even while it was being emptied.
Hrm....
That's bad, I moved that out of the lock on purpose to avoid deadlocks, I think ppc_md.log_error can take the rtas lock again (nvram). We need to take a separate lock for the err buf if that function can be called concurrently I suppose.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |