lkml.org 
[lkml]   [2004]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Add PCDP console detection support
On Fri, Jun 25, 2004 at 03:04:50PM -0600, Bjorn Helgaas wrote:
> This moves the code from drivers/serial/8250_hcdp.[ch] to
> drivers/firmware/pcdp.[ch], since it's no longer 8250-specific.
> It also obsoletes CONFIG_SERIAL_8250_HCDP, replacing it with
> CONFIG_EFI_PCDP (which defaults to Y for ia64).

I'm happy with this. The only thing I spotted on a quick read through
was:

> +static void __init
> +setup_serial_console(int rev, struct pcdp_uart *uart)
> +{
> +#ifdef CONFIG_SERIAL_8250_CONSOLE
>...
> + if (uart->addr.address_space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) {
> + port.mapbase = uart->addr.address;
> + port.membase = ioremap(port.mapbase, 64);

What if ioremap fails (can it fail here?)

> + port.iotype = SERIAL_IO_MEM;

Should be UPIO_MEM please. Seems I missed this in the HCDP code...

> + } else if (uart->addr.address_space_id == ACPI_ADR_SPACE_SYSTEM_IO) {
> + port.iobase = uart->addr.address;
> + port.iotype = SERIAL_IO_PORT;

Likewise should be UPIO_PORT please.


--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site