[lkml]   [2004]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/4]Diskdump Update
On Thu, 17 Jun 2004 14:39:06 +0100, Christoph Hellwig wrote:

>> >please make it not a module of it's own but part of the
>> >scsi code,
>> Do you mean scsi_dump module should be merged with sd_mod.o or scsi_mod.o?

It is difficult because disk_dump and scsi_dump try to check checksum of
itself using check_crc_module so as to confirm whether module is
compromised or not.

static int
scsi_dump_sanity_check(struct disk_dump_device *dump_device)
struct scsi_device *sdev = dump_device->device;
struct Scsi_Host *host = sdev->host;
int adapter_sanity = 0;
int sanity = 0;

if (!check_crc_module()) {
Err("checksum error. scsi dump module may be compromised.
return -EINVAL;

Therefore, scsi_dump need to be always compiled as independent module.
If scsi_dump is merged with scsi_mod, scsi_mod is not able to be
compiled statically.

Best Regards,
Takao Indoh
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 14:04    [W:0.262 / U:0.300 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site