Messages in this thread Patch in this message |  | | | Subject | [PATCH] Export msi_remove_pci_irq_vectors | | From | Roland Dreier <> | | Date | Mon, 21 Jun 2004 21:03:22 -0700 |
| |
As a followup to my previous post about the request_mem_region in msi.c, I noticed that the region is only released in msi_remove_pci_irq_vectors(). Based on the fact that this function is declared in linux/pci.h (and stubbed out if CONFIG_PCI_USE_VECTOR is not defined), I'm guessing that the intent is for a device driver to unconditionally call this when exiting.
However, a module can't call msi_remove_pci_irq_vectors unless the symbol is exported... so if this is the way to do things, please apply this patch.
On the other hand, MSI-HOWTO.txt seems to imply that the 0th MSI vector should be cleaned up just by calling free_irq... so should pci_disable_msi be calling msi_remove_pci_irq_vectors?
- Roland
Index: linux-2.6.7/drivers/pci/msi.c =================================================================== --- linux-2.6.7.orig/drivers/pci/msi.c 2004-06-15 22:20:03.000000000 -0700 +++ linux-2.6.7/drivers/pci/msi.c 2004-06-21 20:51:33.000000000 -0700 @@ -1011,3 +1011,4 @@ EXPORT_SYMBOL(pci_enable_msi); EXPORT_SYMBOL(msi_alloc_vectors); EXPORT_SYMBOL(msi_free_vectors); +EXPORT_SYMBOL(msi_remove_pci_irq_vectors); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |