Messages in this thread | | | Date | Tue, 22 Jun 2004 17:12:36 +0200 | From | Jan-Benedict Glaw <> | Subject | Re: Stop the Linux kernel madness |
| |
On Tue, 2004-06-22 16:38:15 +0200, Petr Vandrovec <VANDROVE@vc.cvut.cz> wrote in message <A095D7F069C@vcnet.vc.cvut.cz>: > On 22 Jun 04 at 4:06, Andrea Arcangeli wrote:
> FYI, vmware modules broke during your change because 2.4.20-xx kernels from > RedHat moved page_count() from linux/mm.h to linux/mm_inline.h, and made > it unavailable for non-GPL modules. So we had to do > > #ifndef page_count > #define page_count(p) (p)->count > #endif > > and this #ifndef test was broken by making page_count inline function.
Just merge the vmware modules upstream. Then, such breakage will be detected early and probably fixed without putting a lot of work into it (from your point of view).
MfG, JBG
-- Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); [unhandled content-type:application/pgp-signature] | |