Messages in this thread | | | Date | Mon, 21 Jun 2004 10:36:44 +0300 | From | Dan Aloni <> | Subject | Re: [PATCH] missing NULL check in drivers/char/n_tty.c |
| |
On Sun, Jun 20, 2004 at 11:58:24PM -0700, Andrew Morton wrote: > Dan Aloni <da-x@gmx.net> wrote: > > > > The rest of the kernel treats tty->driver->chars_in_buffer as a possible > > NULL. This patch changes normal_poll() to be consistent with the rest of > > the code. > > It would be better to change the rest of the kernel - remove the tests. > > If any driver fails to implement ->chars_in_buffer() then we get a nice > oops which tells us that driver needs a stub handler.
Are you sure that it won't affect the logic in tty_wait_until_sent() drastically? It acts quite differently when ->chars_in_buffer == NULL.
-- Dan Aloni da-x@colinux.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |