Messages in this thread | | | Date | Sun, 20 Jun 2004 10:49:29 +0200 | From | Jan-Benedict Glaw <> | Subject | Re: [PATCH] Stop printk printing non-printable chars |
| |
On Sun, 2004-06-20 00:02:58 -0400, Albert Cahalan <albert@users.sf.net> wrote in message <1087704177.8185.951.camel@cube>: > > Get real: either you *want* to get those codes > > interpreted (think about full-blown ncurses apps > > being run over serial link), or you *don't* (think > > about simply recording serial console's output). > > You just have to choose the correct application > > for your task. > > If there are full-blown ncurses apps being routed > through printk -- that is, the KERNEL log -- then > we have far bigger issues.
You're right, I mixed up the ways for console output and for userspace apps using a shell over the very same serial line (what I commonly do).
> The 0x9b character must be blocked, at least when > a serial console is in use. (apps on such a console > may of course use 0x9b as desired -- just not printk)
I still don't see a need to filter out *anything*. To be exact, I've seen other places where a \r is added when a \n occures. Not always a great idea, too... Just keep it as it is, I think it's fine...
MfG, JBG
-- Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA)); [unhandled content-type:application/pgp-signature] | |