lkml.org 
[lkml]   [2004]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] new device support for forcedeth.c second try
Date
On Saturday 19 of June 2004 16:35, Carl-Daniel Hailfinger wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > On Saturday 19 of June 2004 15:55, Francois Romieu wrote:
> >>Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net> :
> >>[...]
> >>
> >>>+static int phy_reset(struct net_device *dev)
> >>>+{
> >>>+ struct fe_priv *np = get_nvpriv(dev);
> >>>+ u32 miicontrol;
> >>>+ u32 microseconds = 0;
> >>>+ u32 milliseconds = 0;
> >>>+
> >>>+ miicontrol = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
> >>>+ miicontrol |= BMCR_RESET;
> >>>+ if (mii_rw(dev, np->phyaddr, MII_BMCR, miicontrol)) {
> >>>+ return -1;
> >>>+ }
> >>>+
> >>>+ //wait for 500ms
> >>>+ mdelay(500);
> >>>+
> >>>+ //must wait till reset is deasserted
> >>>+ while (miicontrol & BMCR_RESET) {
> >>>+ udelay(NV_MIIBUSY_DELAY);
> >>>+ miicontrol = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
> >>>+ microseconds++;
> >>>+ if (microseconds == 20) {
> >>>+ microseconds = 0;
> >>>+ milliseconds++;
> >>>+ }
> >>>+ if (milliseconds > 50)
> >>>+ return -1;
> >>>+ }
> >>>+ return 0;
> >>>+}
> >>
> >>Afaiks this function is not called from a spinlocked nor is it
> >>time-critical. You should make it use schedule_timeout().
>
> Thanks for highlighting the above code. I saw it and wanted to fix it, but
> then I got sidetracked and forgot.
>
> > msleep()
>
> Bartlomiej, could you prepare a patch to move the msleep() function from
> drivers/scsi/libata-core.c to include/linux/delay.h ? This is going to
> benefit users besides libata.

gregkh did this already in 2.6.7

cheers.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.039 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site