Messages in this thread | | | Date | Sat, 19 Jun 2004 03:08:34 -0700 | From | Andrew Morton <> | Subject | Re: [patch 2.6.7] bug_smp_call_function |
| |
William Lee Irwin III <wli@holomorphy.com> wrote: > > Keith Owens <kaos@sgi.com> wrote: > >> sg.c has been fixed to no longer call vfree() with interrupts disabled. > >> Change smp_call_function() from WARN_ON to BUG_ON when interrupts are > >> disabled. It was only set to WARN_ON because of sg.c. > > On Sat, Jun 19, 2004 at 02:44:16AM -0700, Andrew Morton wrote: > > I prefer the WARN_ON. It is exceedingly unlikely that the bug will cause > > lockups or memory/data corruption or anything else, so why nuke the user's > > box when we can trivially continue? > > We'll be sent the bug report either way. > > Calls to smp_call_function() with interrupts off or spinlocks held > typically causes deadlocks on SMP systems.
No, this doesn't "typically" deadlock. It will deadlock on every ten millionth call. The preceding 9,999,999 warnings should have imparted sufficient clue?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |