Messages in this thread | | | Subject | Re: [Bug 2905] New: Aironet 340 PCMCIA card not working since 2.6.7 | Date | Fri, 18 Jun 2004 11:39:07 -0400 | From | Horst von Brand <> |
| |
Jesper Juhl <juhl-lkml@dif.dk> said: > Guennadi Liakhovetski <g.liakhovetski@gmx.de> said: > > - skb = dev_alloc_skb( len + hdrlen + 2 ); > > + skb = dev_alloc_skb( len + hdrlen + 2 + 2 ); > > nitpicking, but why not > skb = dev_alloc_skb( len + hdrlen + 4 ); > ?
- It makes no difference (C forces constant expresions to be computed at compile time) - It _does_ matter if the 2 + 2 is clearer than 4 -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |