lkml.org 
[lkml]   [2004]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: rwsem-spinlock error
On 2004.06.17 11:35, Nick Piggin wrote:
> Geert Uytterhoeven wrote:
>> On Wed, 16 Jun 2004, Marcelo Tosatti wrote:
>>
>>> <nickpiggin:yahoo.com.au>:
>>> o rwsem race fixes backported from 2.6
>>
>>
>>> Nuno Monteiro:
>>> o Fix rwsem-fix typo
>>> o Complete rwsem typo fix
>>
>>
>> | rwsem-spinlock.c: In function `__rwsem_wake_one_writer':
>> | rwsem-spinlock.c:111: `tsk' undeclared (first use in this function)
>> | rwsem-spinlock.c:111: (Each undeclared identifier is reported only
>> once
>> | rwsem-spinlock.c:111: for each function it appears in.)
>>
>> How can this ever compile on any architecture?
>>
>
> Dangit. rwsem-spinlock.c isn't compiled for many architectures.
>
> It should just require a
>
> struct task_struct *tsk;
>


Yeah, m68k being one of those that need it, hence why Geert noticed
immediately. I only tested on x86, ppc32 and alpha, none of which
needs it. This should do the trick, then.



--- linux-2.4/lib/rwsem-spinlock.c~fix-rwsem-race-fix-3 2004-06-16 21:50:49.000000000 +0100
+++ linux-2.4/lib/rwsem-spinlock.c 2004-06-17 13:58:19.833211128 +0100
@@ -101,6 +101,7 @@ static inline struct rw_semaphore *__rws
static inline struct rw_semaphore *__rwsem_wake_one_writer(struct rw_semaphore *sem)
{
struct rwsem_waiter *waiter;
+ struct task_struct *tsk;

sem->activity = -1;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.049 / U:3.700 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site