![]() | |||||||||||||
Messages in this thread |
Hi,
>Leak memory. I also tend to depend on the fact that kfree(NULL) works
>just fine:
>
>err_kfree:
> kfree(cfginfo);
> kfree(def_cte);
> kfree(tbuf);
> printk(KERN_NOTICE "ide-cs: ide_config failed memory allocation\n");
> goto failed;
>
>Makes the error path a little simpler.
>
>
Nope. It will deadlock just like the original patch because failed falls
through to err_kfree which then will jump to failed...
Regards,
Florian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
| ||||||||||||
| Last update: 2005-03-22 14:03 [from the cache] ©2003-2008 | |||||||||||||