Messages in this thread | | | Date | Wed, 16 Jun 2004 08:12:14 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] s390: lost dirty bits. |
| |
On Tue, Jun 15, 2004 at 09:09:19PM -0700, Andrew Morton wrote: > #define ClearPageReferenced(page) clear_bit(PG_referenced, &(page)->flags) > #define TestClearPageReferenced(page) test_and_clear_bit(PG_referenced, &(page)->flags) > > -#ifndef arch_set_page_uptodate > -#define arch_set_page_uptodate(page) do { } while (0) > +#ifdef arch_set_page_uptodate > +#define SetPageUptodate(page) arch_set_page_uptodate(page) > +#else > +#define SetPageUptodate(page) set_bit(PG_uptodate, &(page)->flags) > #endif
Eek. It looks like SetPageUptodate, it smells like SetPageUptodate, why do you give it another name? Just put a
#ifndef SetPageUptodate /* S390 wants to override this */ #define SetPageUptodate set_bit(PG_uptodate, &(page)->flags) #endif
in mm.h
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |