lkml.org 
[lkml]   [2004]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] [STACK] >3k call path in ide
    Date
    Hi,

    > failed:
    > ide_release(link);
    > link->state &= ~DEV_CONFIG_PENDING;
    >
    > + /* memory allocation errors */
    > +err_cisparse:
    > + kfree(cfginfo);
    > +err_cfginfo:
    > + kfree(def_cte);
    > +err_def_cte:
    > + kfree(tbuf);
    > +err_tbuf:
    > + printk(KERN_NOTICE "ide-cs: ide_config failed memory allocation\n");
    > + goto failed;
    > } /* ide_config */

    Huh? This will either leak memory (non alloc error case) or deadlock (mem
    alloc error case). I'm missing something?

    Best,
    Florian
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:0.033 / U:0.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site