Messages in this thread | | | Date | Tue, 15 Jun 2004 20:04:35 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] security_sk_free void return fixup |
| |
On Tue, 15 Jun 2004, Andrew Morton wrote: > > > > I'm going to remove this warning from sparse. Apparently it is valid C99, > > yes, but in every(?) case where it triggered, the kernel code was wrong.
Is that true? Hmm. That would indeed be a strong argument. However, I was also a bit alarmed by how one of the fixes for this warning was itself actually buggy by dropping the "return" statement altogether and falling through.
> So I'd suggest the warning be retained, perhaps with an option to enable > it.
Hmm. Sparse already has a "verbose" level, although right now it's not actually used by anything (it used to enable some warnings that were due to sparse deficiencies, but I fixed that particular problem).
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |