Messages in this thread | | | Date | Tue, 15 Jun 2004 10:01:58 -0700 | Subject | Re: [3/12] remove irda usage of isa_virt_to_bus() | From | Jean Tourrilhes <> |
| |
On Tue, Jun 15, 2004 at 02:12:19AM -0700, William Lee Irwin III wrote: > On Mon, Jun 14, 2004 at 06:43:44PM -0700, Jean Tourrilhes wrote: > > Could you please send this directly to me. I hate scrubbing > > large patches from the mailing list archive. > > Note that before even thinking of pushing this patch in the > > kernel, we need to perform testing with the hardware on i386 and > > potentially on ARM. The author only tried with irtty that doesn't use > > this function, so that's not a valid test at all. Finding people test > > those changes is going to be tough, as usual. > > I'm also wondering about the validity of those changes, but > > that's another matter I need to go through. During 2.5.X, some people > > assured me that using isa_virt_to_bus was safe on all platform with an > > ISA bus... > > Okay, well, I myself didn't produce this, and I couldn't tell offhand > if it was bogus or not.
I can't either, that's why we need to check it.
> I presumed bugreporter made happy and spraying > it across the debian userbase was enough to verify it at runtime. From > what you're telling me, this is not the case.
IrDA is a special case because there are few users and most are still using 2.4.X.
> Can you recommend people to do this kind of testing?
Me. I'll also post the patch to the linux-irda mailing list.
> Apparently people aren't entirely happy with "dump it on lkml and wait > for an ack or nak", which I've noted for future reference, but probably > won't have a need to consider again (it's very rare that I have to deal > with changes I didn't write myself or are otherwise in areas I don't > have much knowledge about).
I'm not a full time Linux hacker, I follow lkml from the archive. No big deal.
> OTOH, it was easier to find than buried in > a distro BTS and/or cvs, not that that makes it ideal.
Debian is usually very good sending me bug reports (especiall on wireless tools), so I'm a bit surprised that it did not work this time. But I've seen a recent trend by Debian to do more Debian specific stuff for system level config, which I find disturbing.
> -- wli
Thanks !
Jean - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |