lkml.org 
[lkml]   [2004]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fix memory leak in swsusp
On Fri, Jun 11, 2004 at 09:00:59PM -0700, Andrew Morton wrote:
> Nigel Cunningham <ncunningham@linuxmail.org> wrote:
> >
> > We were avoiding the use of memcpy because it messes up the preempt count with 3DNow, and
> > potentially as other unseen side effects. The preempt could possibly simply be reset at resume time,
> > but the point remains.
>
> eh? memcpy just copies memory. Maybe your meant copy_*_user()?

See arch/i386/lib/memcpy.c The 3dnow routine does kernel_fpu_begin()/..end()
which futzes with preempt count. What I'm missing though is that the count
afterwards should be the same as it was before the memcpy. Why is this
a problem for the suspend folks?

Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.177 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site