Messages in this thread | | | Date | Sat, 12 Jun 2004 13:17:30 +1000 | From | Nigel Cunningham <> | Subject | Re: Fix memory leak in swsusp |
| |
Hi.
Herbert Xu wrote:
[...]
> + pm_pagedir_nosave = > + memcpy(m, old_pagedir, > + PAGE_SIZE << pagedir_order);
[...]
> + pagedir_nosave = > + memcpy(m, old_pagedir, PAGE_SIZE << pagedir_order); > } > > c = eaten_memory;
We were avoiding the use of memcpy because it messes up the preempt count with 3DNow, and potentially as other unseen side effects. The preempt could possibly simply be reset at resume time, but the point remains.
Regards,
Nigel -- Nigel & Michelle Cunningham C/- Westminster Presbyterian Church Belconnen 61 Templeton Street, Cook, ACT 2614. +61 (417) 100 574 (mobile)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |