Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH 0/3] Couple of sysfs patches | Date | Thu, 10 Jun 2004 01:40:29 -0500 |
| |
On Wednesday 09 June 2004 06:19 pm, Greg KH wrote: > On Wed, Jun 09, 2004 at 05:54:23PM -0500, Dmitry Torokhov wrote: > > On Wednesday 09 June 2004 05:45 pm, Greg KH wrote: > > > On Wed, Jun 09, 2004 at 05:32:28PM -0500, Dmitry Torokhov wrote: > > > > Actually, I myself want someting else - > > > > > > > > int platform_device_register_simple(struct platform_device **ppdev, > > > > const char *name, int id) > > > > > > > > It will allocate platform device, set name and id and release function to > > > > platform_device_simple_release which in turn will be hidden from outside > > > > world. Since the function does allocation for user is should prevent the > > > > abuse you were concerned about. > > > > > > Ok, that sounds good. I'll take patches for that kind of interface. > > > > > > But have the function return the pointer, like the class_simple > > > functions work. Not the ** like you just specified. > > > > I want to do both allocation + registration in one shot and I knowing > > the error code may be important to users. > > That's fine to do. Again, look at how the class_simple_create() > function works. If an error happens, convert it to ERR_PTR() and return > that. The caller can check it with IS_ERR() and friends.
I apologize, I wrote above hastily, without looking at class_simple_create implementation.
Please take a look at the new version of patces. I changed the order so whitespace changes are on 3rd place to ease merging. The patches are against tonight's bk pull from Linus' tree.
There is also 4th patch that allows a device driver to register/unregister a new device on the same bus from driver's probe/remove routine. I need this functionality for implementing pass-through ports, I tried to work around sysfs limitation but it was too ugly for words.
Please let me know what you think.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |