lkml.org 
[lkml]   [2004]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Finding user/kernel pointer bugs [no html]
    On Thu, Jun 10, 2004 at 12:32:08PM -0700, Greg KH wrote:
    > Hm, so we should ignore the sparse warning about the original then?

    IMO that warning is bogus in case of <op>= and if getting rid of a warning
    obfuscates the code...

    > > > - data_ptrs = (u8 **) kmalloc(rdwr_arg.nmsgs * sizeof(u8 *),
    > > > - GFP_KERNEL);
    > > > + data_ptrs = kmalloc(rdwr_arg.nmsgs * sizeof(u8 __user *), GFP_KERNEL);
    > >
    > > While we are at it, what's the type of ->nmsgs?
    >
    > include/linux/i2c-dev.h states it is __u32. Any problems with that?

    Nevermind - it's checked several lines above...
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:0.021 / U:59.724 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site