Messages in this thread | | | Date | Thu, 10 Jun 2004 20:38:24 +0100 | From | viro@parcelfa ... | Subject | Re: Finding user/kernel pointer bugs [no html] |
| |
On Thu, Jun 10, 2004 at 12:32:08PM -0700, Greg KH wrote: > Hm, so we should ignore the sparse warning about the original then?
IMO that warning is bogus in case of <op>= and if getting rid of a warning obfuscates the code...
> > > - data_ptrs = (u8 **) kmalloc(rdwr_arg.nmsgs * sizeof(u8 *), > > > - GFP_KERNEL); > > > + data_ptrs = kmalloc(rdwr_arg.nmsgs * sizeof(u8 __user *), GFP_KERNEL); > > > > While we are at it, what's the type of ->nmsgs? > > include/linux/i2c-dev.h states it is __u32. Any problems with that?
Nevermind - it's checked several lines above... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |