Messages in this thread | | | Subject | Re: Resume enhancement: restore pci config space | From | Arjan van de Ven <> | Date | Tue, 01 Jun 2004 17:06:38 +0200 |
| |
> int xxx_resume(struct pci_dev *dev) > { > int err; > if ((err = pci_default_resume(dev)) < 0) > return err; > // ... do h/w specific > }
well define "h/w specific", just give me an example of a real (alsa?) driver that would use it (or point me to one) so that I can see if this is the best API, what the return value should be etc etc > > > but IMO, the jobs of pci_default_suspend/resume() should be applied > always after/before calling driver's suspend/resume callbacks.
I would be very wary of unconditionally doing the resume thing without the driver having had a chance to do it's thing. Imo the driver HAS to be able to override stuff or at least talk to the hw before the generic resume happens.
[unhandled content-type:application/pgp-signature]
| |