lkml.org 
[lkml]   [2004]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rmap 24 no rmap fastcalls
On Sat, 8 May 2004, Christoph Hellwig wrote:
> > /*
> > - * The warning below may appear if page_referenced catches the
> > - * page in between page_add_{anon,file}_rmap and its replacement
> > + * The warning below may appear if page_referenced_anon catches
> > + * the page in between page_add_anon_rmap and its replacement
>
> is this backing out of my comment fixup intentional? :)

I wouldn't dare! No, look again, it doesn't back it out, it refines
it to refer solely to page_add_anon_rmap, page_add_file_rmap is not
relevant here - your fixup was that the original comment still said
page_add_rmap after that had been replaced by anon, file variants.

What was not intentional was having two rmap 24s:
this was the real 24, and the pte_young one should have said 25.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site