lkml.org 
[lkml]   [2004]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.6-rc3-mm2 (4KSTACK)
On Fri, May 07, 2004 at 10:47:56AM -0500, Steve Lord wrote:
> >- if (mlen > sizeof(buf))
> >+ obj.data = kmalloc(1024, GFP_KERNEL);
> >+ if (!obj.data)
> >+ return -ENOMEM;
> >+
> >+ if (mlen > 1024) {
>
> That's what I hate about all of this, just think how much stack that
> kmalloc can take in low memory situations.... it might end up in
> writepage on another nfs file....

it clearly needs to be GFP_NOFS
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.067 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site