lkml.org 
[lkml]   [2004]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Force IDE cache flush on shutdown

On Thu, May 06, 2004 at 01:33:09PM +0200, Arjan van de Ven wrote:
> On Thu, May 06, 2004 at 11:52:20AM +0100, Christoph Hellwig wrote:
> > > + idedisk_driver.gen_driver.shutdown = ide_drive_shutdown;
> >
> > isn't idedisk_driver initialized statically somewhere? You should probably
>
> ok ok you win
>
> diff -purN linux-2.6.5/drivers/ide/ide-disk.c linux/drivers/ide/ide-disk.c
> --- linux-2.6.5/drivers/ide/ide-disk.c 2004-05-06 13:26:53.350284720 +0200
> +++ linux/drivers/ide/ide-disk.c 2004-05-06 13:32:01.322465832 +0200
> @@ -1725,6 +1725,9 @@ static ide_driver_t idedisk_driver = {
> .drives = LIST_HEAD_INIT(idedisk_driver.drives),
> .start_power_step = idedisk_start_power_step,
> .complete_power_step = idedisk_complete_power_step,
> + .gen_driver = {
> + .shutdown = ide_drive_shutdown,
> + },


and that needs a prototype as well

--- linux-2.6.5/drivers/ide/ide-disk.c~ 2004-05-06 13:44:41.052969240 +0200
+++ linux-2.6.5/drivers/ide/ide-disk.c 2004-05-06 13:44:41.053969088 +0200
@@ -1701,6 +1701,7 @@
}

static int idedisk_attach(ide_drive_t *drive);
+static int ide_drive_shutdown(struct device * dev);

/*
* IDE subdriver functions, registered with ide.c
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:02    [from the cache]
©2003-2011 Jasper Spaans