lkml.org 
[lkml]   [2004]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Force IDE cache flush on shutdown
    On Thu, May 06, 2004 at 08:49:18AM +0100, Christoph Hellwig wrote:
    > On Thu, May 06, 2004 at 09:04:49AM +0200, Arjan van de Ven wrote:
    > > +static int ide_disk_notify_reboot (struct notifier_block *this, unsigned long event, void *x)
    > > +{
    > > + ide_hwif_t *hwif;
    > > + ide_drive_t *drive;
    > > + int i, unit;
    > > +
    > > + switch (event) {
    > > + case SYS_HALT:
    > > + case SYS_POWER_OFF:
    > > + break;
    > > + default:
    > > + return NOTIFY_DONE;
    > > + }
    >
    > Please don't use reboot notifiers in new driver code. The driver
    > model has a ->shutdown method for that.

    there is somewhat of a problem with that; the reboot command potentially
    runs from the disk in question, so that might never get called since that
    will keep things busy.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:0.028 / U:0.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site