lkml.org 
[lkml]   [2004]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6.6-rc3-mm2] genhd-unregister warn handling
FabF <Fabian.Frederick@skynet.be> wrote:
>
> Here's a patch against 2.6.6-rc3-mm2 genhd.c unregister_blkdev
>
> -Standardize function for void xxx
> -Split uncorresponding return
> -Add printks
> -Merge kfree to positive case
>
> Could you apply ?

It seems to be a gratuitous change to the modules API.

A quick grep shows that a lot of drivers are currently testing the
unregister_blkdev() return value - your patch breaks them all.

I don't see much point in making changes in this area.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.056 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site