Messages in this thread | | | Date | Thu, 6 May 2004 09:29:43 -0700 | From | Brad Boyer <> | Subject | Re: [OPERA] Potential bugs detected by static analysis tool in 2.6.4 |
| |
On Thu, May 06, 2004 at 11:43:45AM +0200, Geert Uytterhoeven wrote: > On Wed, 5 May 2004, Zhenmin Li wrote: > > 8. /arch/m68k/mac/iop.c, Line 164: > > Should be line 264?
Perhaps they cut out the comments before counting lines? There are around 100 lines of comments at the top explaining the whole mess.
In any case, line 264 sounds right. It's shortly after
if(macintosh_config->adb_type == MAC_ADB_IOP) {
> > iop_base[IOP_NUM_SCC]->status_ctrl = 0; > > > > Maybe change to: > > iop_base[IOP_NUM_ISM]->status_ctrl = 0; > > Mac guys, is this correct?
Actually, I think it is. It looks like this is a bug that crept in during the last IOP rewrite (back in 2.2). It's not the same line number in 2.2 and 2.4, but there is a similar situation. I'll see if I can find some time to get my Mac IIfx running again and try out a fix. I did get a 2.6 kernel running on it once before.
And as a note to the person who reported this, please include at least a line or two of context around the change. If you use diff -u, that's even better.
Brad Boyer flar@allandria.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |