lkml.org 
[lkml]   [2004]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: workqueue and pending
    From
    Date

    > static inline int cancel_delayed_work(struct work_struct *work)
    > {
    > - return del_timer_sync(&work->timer);
    > + int ret;
    > +
    > + ret = del_timer_sync(&work->timer);
    > + if (ret)
    > + clear_bit(0, &work->pending);
    > + return ret;
    > }

    Heh, I was trying to figure out a simple way to do that and just
    didn't figure out del_timer_sync() would actually have a useful
    return value :)

    It's probably still good to precise explicitely in the comments
    that upon return of cancel_delayed_work(), the work queue might
    still be pending and that a flush and whoever called this may
    still need a flush_scheduled_work() or flush_workqueue() (provided
    it's running in a context where that can sleep)

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:0.019 / U:1.700 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site