![]() | |||||||||||||
Messages in this thread |
On Thu, 27 May 2004 14:51:34 +0100, Christoph Hellwig wrote: >> +/******************************** Disk dump **************************** >> *******/ >> +#if defined(CONFIG_DISKDUMP) || defined(CONFIG_DISKDUMP_MODULE) >> +#undef add_timer >> +#define add_timer diskdump_add_timer >> +#undef del_timer_sync >> +#define del_timer_sync diskdump_del_timer >> +#undef del_timer >> +#define del_timer diskdump_del_timer >> +#undef mod_timer >> +#define mod_timer diskdump_mod_timer >> + >> +#define tasklet_schedule diskdump_tasklet_schedule >> +#endif > >Yikes. No way in hell we'll place code like this in drivers. This needs >to be handled in common code. Another method is to add codes for diskdump into add_timer/del_timer/etc itself, but I don't think it is good method. Do you have any good idea? Best Regards, Takao Indoh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 14:03 [from the cache] ©2003-2008 | |||||||||||||