Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: idebus setup problem (2.6.7-rc1) | Date | Thu, 27 May 2004 17:51:04 +0200 |
| |
On Thursday 27 of May 2004 17:21, Zhu, Yi wrote: > Bartlomiej Zolnierkiewicz [B.Zolnierkiewicz@elka.pw.edu.pl] wrote: > > I remember seeing patch related to handling '=' in kernel > > params, maybe it's related (or maybe not). > > Yes, this is caused by my kernel-parameter-parsing-fix.patch. > > But I think below code in ide.c is a hack. > __setup("", ide_setup);
It is a really bad hack but unfortunately it is not easy to fix. We can only do it by introducing new kernel parameters and obsoleting current braindamage (+ halting boot if obsolete parameter is detected).
Please note that in (very) rare corner cases current breakage can cause data corruption.
> How about below change?
It breaks all "idex=" and "hdx=" options. Please take a look at how ide_setup().
> --- linux-2.6.7-rc1-mm1.orig/drivers/ide/ide.c 2004-05-27 > 23:07:59.405138992 +0800 > +++ linux-2.6.7-rc1-mm1/drivers/ide/ide.c 2004-05-27 > 23:09:47.529701560 +0800 > @@ -2459,7 +2459,8 @@ void cleanup_module (void) > > #else /* !MODULE */ > > -__setup("", ide_setup); > +__setup("hd", ide_setup); > +__setup("ide", ide_setup); > > module_init(ide_init); > > > -yi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |