lkml.org 
[lkml]   [2004]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] export swapper_space
James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> This is now used as part of the page_mapping() macro. However, certain
> filesystems, such as ext3, make use of this. If it's not exported, they
> can't be compiled as modules.

I'd be a bit reluctant to do this. filesystems actually have no need for
page_mapping() - page->mapping is always correct in that context and
page_mapping() has additional overhead. So if poss we should avoid this
export so as to force filesystems to avoid page_mapping().

parisc broke because its flush_dcache_page() is inlined, and it uses
page_mapping(). I'd suggest that parisc and arm uninline that function -
it's quite large anyway.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [from the cache]
©2003-2011 Jasper Spaans