Messages in this thread | | | Date | Fri, 21 May 2004 10:11:37 +0200 | From | Jens Axboe <> | Subject | Re: [2.6.6-mm4-ff1] I/O context isolation |
| |
On Fri, May 21 2004, Nick Piggin wrote: > FabF wrote: > >On Fri, 2004-05-21 at 09:38, Nick Piggin wrote: > > > >>FabF wrote: > >> > >>>Jens, > >>> > >>> Here's ff1 patchset to have generic I/O context. > >>>ff1 : Export io context operations from blkdev/ll_rw_blk (ok) > >>>ff2 : Make io_context generic plateform by importing IO stuff from > >>>as_io. > >>> > >> > >>Can I just ask why you want as_io_context in generic code? > >>It is currently nicely hidden away in as-iosched.c where > >>nobody else needs to ever see it. > > > >I do want I/O context to be generic not the whole as_io. > >That export should bring: > > -All elevators to use io_context > > -source tree to be more self-explanatory > > -have a stronger elevator interface > > > > Sorry, my mistake. as_io_context is not nicely hidden away at > the moment. I can't remember why, I think it is only needed > for the declaration... I'll look into moving it into as-iosched.c > > *But*, io_context is already exported to all elevators and generic > code.
That was my initial complaint about it as well, however solving it makes it even more ugly I think. It's a layering violation. I guess with a simply ->dtor and ->exit + io_private_data it would be fine, but I'd say don't bother now (it's 2.6.6).
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |