lkml.org 
[lkml]   [2004]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()
Arthur Othieno wrote:
> Hi,
>
> We're prematurely pampering the request queue before
> checking whether it was indeed allocated successfully.
>
> Against 2.6.6. Thanks.
>
>
> floppy.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/block/floppy.c 2004-05-20 23:48:04.000000000 +0200
> +++ b/drivers/block/floppy.c 2004-05-21 21:29:33.000000000 +0200
> @@ -4271,11 +4271,11 @@
> goto out;
>
> floppy_queue = blk_init_queue(do_fd_request, &floppy_lock);
> - blk_queue_max_sectors(floppy_queue, 64);
> if (!floppy_queue) {
> err = -ENOMEM;
> goto fail_queue;
> }
> + blk_queue_max_sectors(floppy_queue, 64);


Good catch...

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.062 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site