lkml.org 
[lkml]   [2004]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [linux-usb-devel] [PATCH] visor: Fix Oops on disconnect
    From
    > I've made all of the changes that recommended below.  If it looks like
    > I've missed anything, please indicate so.
    >
    >

    [snip]

    >>
    >>>+ if (num_ports <= 0 || num_ports > 2) {
    >>
    >>
    >> I like the idea of this check, but you are trying to test for a negative
    >> value on a __u16 variable, which is always unsigned. So that check will
    >> never be true :)

    What happens if num_ports == 0? Not that hardware should ever report that.

    [snip]

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:0.023 / U:32.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site