lkml.org 
[lkml]   [2004]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ata_piix: port disabled. ignoring.
Geert Uytterhoeven wrote:
> If I try to work around the problem by applying this patch:
>
> --- linux-2.6.6-bk4/drivers/scsi/ata_piix.c.orig 2004-05-17 20:02:25.000000000 +0200
> +++ linux-2.6.6-bk4/drivers/scsi/ata_piix.c 2004-05-17 20:59:15.000000000 +0200
> @@ -330,8 +330,8 @@
> if (!pci_test_config_bits(ap->host_set->pdev,
> &piix_enable_bits[ap->port_no])) {
> ata_port_disable(ap);
> - printk(KERN_INFO "ata%u: port disabled. ignoring.\n", ap->id);
> - return;
> + //printk(KERN_INFO "ata%u: port disabled. ignoring.\n", ap->id);
> + printk(KERN_INFO "ata%u: port disabled. NOT IGNORING!\n", ap->id);
> }
>
> if (!piix_sata_probe(ap)) {
>
> everything works fine, even if I disable the second SATA port in the BIOS:


I think this check is vaguely incorrect, because it sounds like you are
in combined mode. That would imply that ap->port_no is incorrect, for
this one special case. (details: in combined aka legacy mode, port
number is always zero because it is initialized as two separate hosts,
not one host with two ata_ports)

However, since this is SATA, and PIIX does at least give us a "no
device" indication, we could probably just delete the 'if' and the code
you are commenting out as well.

Ponder, ponder...

Another thing I am pondering is detecting combined mode in
drivers/pci/quirks.c, and reconfiguring the motherboard such that is it
no longer in combined mode.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.057 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site