Messages in this thread | | | Subject | Re: [PATCH] Remove bogus WARN_ON in futex_wait | From | Rusty Russell <> | Date | Thu, 20 May 2004 10:52:46 +1000 |
| |
On Wed, 2004-05-19 at 20:50, Andi Kleen wrote: > On Wed, 19 May 2004 13:43:40 +0300 > Muli Ben-Yehuda <mulix@mulix.org> wrote: > > > On Wed, May 19, 2004 at 12:23:50PM +0200, Andi Kleen wrote: > > > > > > futex_wait goes to an interruptible sleep, but does a WARN_ON later > > > if it wakes up early. But waking up early is totally legal, since > > > the sleep is interruptible and any signal can wake it up. > > > > That's not what the WARN_ON is saynig, unless I'm missing > > something. It's checking if we were woken up early and there's no > > signal pending for us. > > True. Anyways, it seems to happen in practice.
Which we've been trying to figure out. We return -EINTR in this case even though it's a lie. Don't know if it breaks anything, but I *really* want to know who the buggy waker is before pronouncing it harmless.
Rusty. -- Anyone who quotes me in their signature is an idiot -- Rusty Russell
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |