lkml.org 
[lkml]   [2004]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: vga16fb broke
> > >  	/* XXX share VGA_FB_PHYS and I/O region with vgacon and others */
> > >
> > > - vga16fb.screen_base = ioremap(VGA_MAP_MEM(VGA_FB_PHYS), VGA_FB_PHYS_LEN);
> > > + vga16fb.screen_base = VGA_MAP_MEM(VGA_FB_PHYS);
> > > if (!vga16fb.screen_base) {
> > > printk(KERN_ERR "vga16fb: unable to map device\n");
> > > ret = -ENOMEM;
> >
> > This will make the driver on all platforms.
>
> There's a missing word in that sentence. Was it "work" or "crash"? This
> matters ;)

works :-)

> > > and that ARM and others need to teach their VGA_MAP_MEM() to do an internal
> > > ioremap().
> > >
> > > Or do you mean something else? Please be more clear?
> >
> > I like to see the VGA_MAP_MEM hack go away and be replaced with ioremap.
>
> If you can cut a patch we can ask arch maintainers to review and test it.

I could but that would take some time. For now apply your fix.
Actually Ihave a newer vga16 driver for you I can push you.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.049 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site