lkml.org 
[lkml]   [2004]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.6-mm3: USB console.c doesn't compile
    On Sun, May 16, 2004 at 08:38:49PM +0200, Adrian Bunk wrote:
    > The following compile error comes from Linus' tree:
    >
    > <-- snip -->
    >
    > ...
    > CC drivers/usb/serial/console.o
    > drivers/usb/serial/console.c: In function `usb_console_setup':
    > drivers/usb/serial/console.c:140: warning: implicit declaration of function `serial_paranoia_check'
    > ...
    > LD .tmp_vmlinux1
    > drivers/built-in.o(.init.text+0x698c8): In function `usb_console_setup':
    > : undefined reference to `serial_paranoia_check'
    > make: *** [.tmp_vmlinux1] Error 1

    Oops, forgot that one, sorry. Here's a patch that fixes it, and I'll
    forward it on to Linus later today.

    thanks,

    greg k-h


    diff -Nru a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
    --- a/drivers/usb/serial/console.c Mon May 17 09:31:11 2004
    +++ b/drivers/usb/serial/console.c Mon May 17 09:31:11 2004
    @@ -137,7 +137,7 @@

    /* grab the first serial port that happens to be connected */
    serial = usb_serial_get_by_index(0);
    - if (serial_paranoia_check (serial, __FUNCTION__)) {
    + if (serial == NULL) {
    /* no device is connected yet, sorry :( */
    err ("No USB device connected to ttyUSB0");
    return -ENODEV;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:4.205 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site