lkml.org 
[lkml]   [2004]   [May]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From(Thomas Gleixner)
Subject[PATCH 2.4.26] drivers/char/keyboard.c fix compiler warnings
DateSat, 15 May 2004 15:00:02 +0200
The patch fixes the following warnings, produced by gcc3.3.3:

keyboard.c: In function `do_fn':
keyboard.c:640: warning: comparison is always true due to limited range of 
data type

SIZE(func_table) is 256. So value can't be >= SIZE(func_table)

-- 
Thomas
________________________________________________________________________
"Free software" is a matter of liberty, not price. To understand the concept,
you should think of "free" as in "free speech,'' not as in "free beer".
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
--- linux-2.4.26.org/drivers/char/keyboard.c	2003-11-28 19:26:20.000000000 
+0100
+++ linux-2.4.26/drivers/char/keyboard.c	2004-05-15 13:35:19.000000000 +0200
@@ -637,11 +637,8 @@
 {
 	if (up_flag)
 		return;
-	if (value < SIZE(func_table)) {
-		if (func_table[value])
-			puts_queue(func_table[value]);
-	} else
-		printk(KERN_ERR "do_fn called with value=%d\n", value);
+	if (func_table[value])
+		puts_queue(func_table[value]);
 }
 
 static void do_pad(unsigned char value, char up_flag)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [from the cache]
©2003-2008